Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error handling to support third-party tools #509

Merged
merged 23 commits into from
Jul 5, 2024

Conversation

rahulyadav-57
Copy link
Member

@rahulyadav-57 rahulyadav-57 commented Jun 28, 2024

Closes #262

  • I have updated CHANGELOG.md
  • [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • [ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

- Replaced consoleLogger with the new Logger
- Removed jest mock where consoleLogger was used
- Improved support for third-party tools
scripts/prepare.ts Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

Any progress here?

@rahulyadav-57 rahulyadav-57 marked this pull request as ready for review July 3, 2024 10:42
src/logger.ts Outdated Show resolved Hide resolved
src/pipeline/build.ts Outdated Show resolved Hide resolved
src/pipeline/build.ts Outdated Show resolved Hide resolved
src/node.ts Outdated Show resolved Hide resolved
src/pipeline/build.ts Outdated Show resolved Hide resolved
src/pipeline/build.ts Outdated Show resolved Hide resolved
anton-trunov
anton-trunov previously approved these changes Jul 5, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @byakuren-hijiri to approve

bin/tact Show resolved Hide resolved
@anton-trunov anton-trunov added this to the v1.4.1 milestone Jul 5, 2024
scripts/prepare.ts Outdated Show resolved Hide resolved
scripts/prepare.ts Outdated Show resolved Hide resolved
scripts/prepare.ts Outdated Show resolved Hide resolved
src/node.ts Outdated Show resolved Hide resolved
anton-trunov and others added 2 commits July 5, 2024 13:42
Co-authored-by: byakuren-hijiri <[email protected]>
Co-authored-by: byakuren-hijiri <[email protected]>
byakuren-hijiri
byakuren-hijiri previously approved these changes Jul 5, 2024
Copy link
Contributor

@byakuren-hijiri byakuren-hijiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's refactor existing sources a little bit and fix the operations with paths to avoid cross-platform problems. After that, LGTM.

@anton-trunov
Copy link
Member

I just pushed two fixes, let's see if the tests are green and merge it

@anton-trunov anton-trunov merged commit 1d6dd06 into tact-lang:main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance error handling in Tact compiler to support third-party tools
4 participants